Avoid some promise object allocations when writing on channel - #16113
Merged
Conversation
merlimat
added
the
type/enhancement
merlimat
requested review from
BewareMyPower,
codelipenghui,
hangc0276 and
lhotari
June 17, 2022 23:19
|
@merlimat Please provide a correct documentation label for your PR. |
merlimat
added
doc-not-needed
Jason918
approved these changes
Jun 20, 2022
Merged
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
If we're not using the future returned by
writeAndFlush(), we can use avoidFutureto prevent any allocations.doc-not-needed